Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Add API for ContentRating descriptions #430

Merged
merged 1 commit into from Aug 25, 2022

Conversation

aleixpol
Copy link
Collaborator

No description provided.

@ximion
Copy link
Owner

ximion commented Aug 25, 2022

I think this patch is okay, but wouldn't you also need a wrapper for as_content_rating_get_rating_ids to make efficient use of this API?

@aleixpol aleixpol force-pushed the work/apol/qt-oars-description branch 2 times, most recently from 0e5f687 to 68c4c89 Compare August 25, 2022 14:39
@aleixpol
Copy link
Collaborator Author

Yep, added

@aleixpol aleixpol force-pushed the work/apol/qt-oars-description branch from 68c4c89 to f5387f8 Compare August 25, 2022 14:40
@ximion
Copy link
Owner

ximion commented Aug 25, 2022

Looks good! I do wonder now whether there will be a time where you'll also want a attributeDescription(id, value) API that isn't dependent on having a ContentRating object, like the C API has. But we could add something like that later, in that case... (or of course follow the C API and have these functions separate, but tbh I don't mind that description() convenience function :)

@aleixpol
Copy link
Collaborator Author

I am not sure in which case we'd need a description without an ContentRatings object.

FWIW, this MR uses this new API https://invent.kde.org/plasma/discover/-/merge_requests/357

@ximion
Copy link
Owner

ximion commented Aug 25, 2022

I am not sure in which case we'd need a description without an ContentRatings object.

Mostly useful if you want to contruct some kind of overview page :-)

@ximion ximion merged commit 327e5e6 into master Aug 25, 2022
16 checks passed
@ximion ximion deleted the work/apol/qt-oars-description branch August 25, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants