Jump to conversation

Unresolved conversations (4)

ximion

Dec 15, 2022

Please use `as_screenshot_kind_from_string`, that will do the right thing here and you get an enum value to compare in the subsequent lines, instead of comparing strings.

src/as-validator.c

ximion

Dec 15, 2022

Please don't add declarations after statements for now...

Outdated

src/as-validator.c

ximion

Dec 15, 2022

Please don't do this. Use `as_screenshot_kind_from_string` and check whether `as_screenshot_kind_from_string (scr_kind_str) == AS_SCREENSHOT_KIND_DEFAULT` (more consistent, easier for refactoring, if you get an `UNKNOWN` you can already raise a validation warning.

Outdated

src/as-validator.c

ximion

Dec 15, 2022

...same for things like `width` if used as meaning the exact, literal name of a tag or property (put in backticks, add translator hint).

Outdated

src/as-validator-issue-tag.h

Resolved conversations (5)

ximion

Dec 15, 2022

Should probably be a WARNING, the data isn't completely broken if this is missing (warnings will still make validation fail).

Outdated

src/as-validator-issue-tag.h

ximion

Dec 15, 2022

typo: default Maybe: "A default screenshot is missing."

Outdated

src/as-validator-issue-tag.h

ximion

Dec 15, 2022

typo: least Maybe: "at least one image of type \`source\`"

Outdated

src/as-validator-issue-tag.h

ximion

Dec 15, 2022

Please put the values like `source` in backticks, and add a hint for translators to not translate these values (see some of the other entries, you can just copy from there).

Outdated

src/as-validator-issue-tag.h

ximion

Dec 15, 2022

nit: If you want to be super pedantic: "must be a *positive* integer" ;-)

Outdated

src/as-validator-issue-tag.h