Jump to conversation
Unresolved conversations (7)
@ximion ximion Dec 16, 2022
Please use either `as_xml_get_node_value` or `as_xml_get_node_value_raw`. You probably want the former and then check for NULL.
src/as-validator.c
ximion JakobDev
@ximion ximion Dec 16, 2022
This is missing a `g_autofree`
src/as-validator.c
ximion JakobDev
@ximion ximion Dec 16, 2022
Please don't mix declarations and statements.
src/as-validator.c
@ximion ximion Dec 16, 2022
nit: This could be one line with the one above it.
src/as-validator.c
@ximion ximion Dec 16, 2022
Unless this causes problems, making this a WARNING or possibly even INFO might be better. That allows some flexibility for writers of custom data (e.g. to have placeholders that are ignored deliberately).
src/as-validator-issue-tag.h
@ximion ximion Dec 16, 2022
=> the \`key\` attribute
src/as-validator-issue-tag.h
@ximion ximion Dec 16, 2022
Again, any literal should be in backticks so translators don't translate it by accident.
src/as-validator-issue-tag.h
Resolved conversations (0)