docs: Clarify the locations where catalog icons should be placed #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximion
requested changes
Jan 29, 2023
ximion
changed the title
pabloyoyoista
force-pushed
the
catalog-icon-location-fix
branch
from
517316a
to
7743471
Compare
Rationale: https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/1574#note_1625290 Co-authored-by: Matthias Klumpp <matthias@tenstral.net>
pabloyoyoista
force-pushed
the
catalog-icon-location-fix
branch
from
7743471
to
07a785e
Compare
|
Nice, looks good now! Thank you for the patch! And removal time of deprecated stuff is AppStream 1.0, maybe I'll have a look at this then as well ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Rationale: https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/1574#note_1625290