Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (10)
@ximion ximion Mar 14, 2023
```suggestion g_assert_false (as_pool_is_empty (dpool)); ```
Outdated
tests/test-pool.c
@ximion ximion Mar 14, 2023
```suggestion guint as_cache_get_component_count (AsCache *cache); ```
Outdated
src/as-cache.h
@ximion ximion Mar 14, 2023
```suggestion return as_cache_get_component_count (priv->cache) == 0; ```
Outdated
src/as-pool.c
@ximion ximion Feb 24, 2023
```suggestion g_assert_false (as_pool_is_empty (dpool)); ```
Outdated
tests/test-pool.c
@ximion ximion Feb 24, 2023
Please don't remove check ;-) - we need this assertion.
Outdated
tests/test-pool.c
@ximion ximion Feb 24, 2023
style and rename ```suggestion return as_cache_get_component_count (priv->cache) > 0; ```
Outdated
src/as-pool.c
@ximion ximion Feb 24, 2023
```suggestion as_pool_is_empty (AsPool* pool) ```
Outdated
src/as-pool.c
@ximion ximion Feb 24, 2023
```suggestion return components->len; ```
Outdated
src/as-cache.c
@ximion ximion Feb 24, 2023
Please make this return a component count instead: ```suggestion guint as_cache_get_component_count (AsCache* cache) ```
Outdated
src/as-cache.c
@ximion ximion Feb 24, 2023
This is *extremely* inefficient, but let's ignore that for now, I can alter the code later to make it more efficient.
src/as-cache.c
aleixpol