Remove common XML methods from xmldata.c #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximion
force-pushed
the
master
branch
8 times, most recently
from
94fcca3
to
96f54e1
Compare
lucasmoura
force-pushed
the
xml_utils
branch
2 times, most recently
from
5de2a01
to
db60bfc
Compare
In order to allow AppStream data to handle different XML data, it is necessary to remove some basic method from xmldata.c, such as parsing an XML document or get the value of an XML node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In order to allow AppStream data to handle different XML data, it is necessary
to remove some basic method from xmldata.c, such as parsing an XML document or
get the value of an XML node.
Although it is possible for any new XML parser to inherit from xmldata, this would not be a good approach, because the new class would inherit a lot of other methods related exclusively to parsing AppStream components, which is not ideal.
Therefore, this MR create an xml-utils file, which holds this common functions.