Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

as_flags_value is broken #64

Closed
wants to merge 2 commits into from
Closed

as_flags_value is broken #64

wants to merge 2 commits into from

Conversation

iainlane
Copy link
Contributor

@iainlane iainlane commented Aug 17, 2016 •
edited

Not sure what you intended here - but the test case doesn't pass, and it doesn't work in asgen either. The values get shifted twice, which means the test never works.

This fixes it for me, but if you had something else in mind then please do that instead. The second commit is just a typo fix.

@iainlane iainlane changed the title as as_flags_value is broken Aug 17, 2016
@iainlane iainlane mentioned this pull request Aug 17, 2016
Merged
@ximion
Copy link
Owner

ximion commented Aug 17, 2016

Hmm, the tests definitely didn't fail (CI approves), but this is an error regardless.
I copied those lines from PackageKit, and PKs PkBitfields are special in some regards.

(Fixed now in master, by dropping the _value method)

@ximion ximion closed this in 4225acf Aug 17, 2016
ximion added a commit that referenced this pull request Aug 17, 2016
@ximion
Fix flag helpers
53536df 
Fix it by removing it

(Thanks to Iain Lane for spotting this error in  #64)

Resolves:  #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iainlane @ximion