Skip to content

Comments

as-cache-file: Iterate the right dictionary when looking at checksums#71

Merged
ximion merged 1 commit intoximion:masterfrom
iainlane:fix-checksum-iter
Sep 6, 2016
Merged

as-cache-file: Iterate the right dictionary when looking at checksums#71
ximion merged 1 commit intoximion:masterfrom
iainlane:fix-checksum-iter

Conversation

@iainlane
Copy link
Contributor

@iainlane iainlane commented Sep 6, 2016

Fixes #70.

On 1084 the checksums dictionary is retrieved, but then we look at var, which is something else entirely.

@ximion
Copy link
Owner

ximion commented Sep 6, 2016

Hehe, I found this yesterday evening before lunch too.
Remind me to extend the testsuite to include this case later.

@ximion ximion merged commit 0686cdc into ximion:master Sep 6, 2016
@iainlane
Copy link
Contributor Author

iainlane commented Sep 6, 2016

Thanks! You might want to protect the setters against NULL being passed in too.

@iainlane iainlane deleted the fix-checksum-iter branch September 6, 2016 09:55
@ximion
Copy link
Owner

ximion commented Sep 6, 2016

That would hide bugs then... Unless I assert on NULL of course.

@iainlane
Copy link
Contributor Author

iainlane commented Sep 6, 2016

I guess you would do a g_critical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants