as-cache-file: Iterate the right dictionary when looking at checksums #71

iainlane · 2016-09-06T09:39:33Z

Fixes #70.

On 1084 the checksums dictionary is retrieved, but then we look at var, which is something else entirely.

ximion · 2016-09-06T09:49:40Z

Hehe, I found this yesterday evening before lunch too.
Remind me to extend the testsuite to include this case later.

iainlane · 2016-09-06T09:55:45Z

Thanks! You might want to protect the setters against NULL being passed in too.

ximion · 2016-09-06T09:59:13Z

That would hide bugs then... Unless I assert on NULL of course.

iainlane · 2016-09-06T10:04:53Z

I guess you would do a g_critical

as-cache-file: Iterate the right dictionary when looking at checksums

fde20d8

Fixes ximion#70.

ximion merged commit 0686cdc into ximion:master Sep 6, 2016

iainlane deleted the fix-checksum-iter branch September 6, 2016 09:55

Conversation