Sort search results by highest to lowest match scores#80
Merged
ximion merged 1 commit intoximion:masterfrom Sep 29, 2016
Merged
Sort search results by highest to lowest match scores#80ximion merged 1 commit intoximion:masterfrom
ximion merged 1 commit intoximion:masterfrom
Conversation
…cores to be at the top of the list. Fixes ximion#77.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the comment header in as_pool_search claims that the results are returned unordered, they are specifically ordered from lowest to highest match score. If search results are going to be sorted, I believe it makes more sense for higher scores to be at the top of the list.
Fixes #77.