Fix database dtor crash #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 as soon as the tests pass. @ximion any idea what happened there? |
in particular this allows catching nullptr access on the ptr member
- only open once - roll back on pool loading errors by unrefing the pool instance again
hsitter
force-pushed
the
fix-database-dtor-crash
branch
from
169287c
to
784b10f
Compare
|
thar she blows. build fixed. all lovely again. I am calling it a day :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
without this an unopened database goes boom because the pointer points to garbage