Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly offer a QIcon from the component #83

Closed
wants to merge 1 commit into from

Conversation

aleixpol
Copy link
Collaborator

Instead of giving the different pieces (which could also be accessible
through the API)

Instead of giving the different pieces (which could also be accessible
through the API)
@ximion
Copy link
Owner

ximion commented Oct 25, 2016

This introduces a dependency on GUI stuff which I was very careful to avoid so far...
I guess the Qt library is highly likely used with GUI stuff in almost all the cases though, unlike the C library which is also used without any GUI stuff at all, which might make this a useful thing for the Qt lib...

Issues I see here are though:

  • No support for remote icons, and introducing it will be trickier
  • No way to select a specific icon size
  • We limit ourselves to the things a QIcon can do, for better or worse.

I need to sleep and think about this tomorrow when I'm more awake.

@ximion
Copy link
Owner

ximion commented Oct 25, 2016

I added a non-GUI icon implementation which also works with remote icons (which will be used much more in future, I assume).
We can still think about adding something QIcon based additionally though, if a GUI dependency is okay for this library...

@aleixpol aleixpol closed this Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants