Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path search to find libstemmer headers #91

Merged
merged 1 commit into from Nov 24, 2016

Conversation

Conan-Kudo
Copy link
Contributor

In Mageia, the libstemmer headers are in /usr/include/libstemmer, while in Fedora and other distributions, they are in /usr/include.

We will now support both paths.

@Conan-Kudo Conan-Kudo changed the title Add path for libstemmer headers to be found Add path search for libstemmer headers to be found Nov 24, 2016
@Conan-Kudo Conan-Kudo changed the title Add path search for libstemmer headers to be found Add path search to find libstemmer headers Nov 24, 2016
@ximion
Copy link
Owner

ximion commented Nov 24, 2016

Looks good, but can you call LIBSTEMMER_INCLUDE_DIR SNOWBALL_INCLUDE_DIR to match the library variable please? (from the minor nitpick category)
Apart from that, the patch looks good to go :-)

In Mageia, the libstemmer headers are in /usr/include/libstemmer,
while in Fedora and other distributions, they are in /usr/include.

We will now support both paths.
@Conan-Kudo
Copy link
Contributor Author

@ximion Done.

@ximion ximion merged commit c5ddfb9 into ximion:master Nov 24, 2016
@ximion
Copy link
Owner

ximion commented Nov 24, 2016

Great, thanks for the patch!

@Conan-Kudo Conan-Kudo deleted the find-stemmer-fix branch November 24, 2016 14:01
@Conan-Kudo
Copy link
Contributor Author

@ximion You're welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants