Skip to content

Comments

Introduce AppStream::Suggested in the Qt frontend#93

Merged
aleixpol merged 1 commit intoximion:masterfrom
aleixpol:master
Nov 27, 2016
Merged

Introduce AppStream::Suggested in the Qt frontend#93
aleixpol merged 1 commit intoximion:masterfrom
aleixpol:master

Conversation

@aleixpol
Copy link
Collaborator

No description provided.

qt/component.cpp Outdated
{
QList<Suggested> res;

auto suggestions = as_component_get_bundles(m_cpt);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is certainly wrong and will explode when converting it to AsSuggested later...

qt/suggested.h Outdated
Q_ENUM(Kind)

Suggested();
Suggested(_AsSuggested *icon);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon?

@ximion
Copy link
Owner

ximion commented Nov 24, 2016

Also, the CI says that this code doesn't compile (and it is right).

@aleixpol
Copy link
Collaborator Author

Should be okay now.

as_suggested_add_id(d->m_suggested, qPrintable(id));
}

QDebug operator<<(QDebug s, const AppStream::Suggested& image) {
Copy link
Owner

@ximion ximion Nov 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Image? (also, bracked should come after a newline for functions)

@aleixpol aleixpol merged commit 11929dd into ximion:master Nov 27, 2016
@ximion
Copy link
Owner

ximion commented Nov 27, 2016

Please do a rebase-merge or squash-merge next time to avoid pointless merge commits.

@aleixpol
Copy link
Collaborator Author

Sorry, I'm not used to github UI. Will pay more attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants