New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce AppStream::Suggested in the Qt frontend #93
Conversation
| { | ||
| QList<Suggested> res; | ||
|
|
||
| auto suggestions = as_component_get_bundles(m_cpt); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is certainly wrong and will explode when converting it to AsSuggested later...
| Q_ENUM(Kind) | ||
|
|
||
| Suggested(); | ||
| Suggested(_AsSuggested *icon); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icon?
|
Also, the CI says that this code doesn't compile (and it is right). |
|
Should be okay now. |
| as_suggested_add_id(d->m_suggested, qPrintable(id)); | ||
| } | ||
|
|
||
| QDebug operator<<(QDebug s, const AppStream::Suggested& image) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Image? (also, bracked should come after a newline for functions)
|
Please do a rebase-merge or squash-merge next time to avoid pointless merge commits. |
|
Sorry, I'm not used to github UI. Will pay more attention. |
No description provided.