Introduce AppStream::Suggested in the Qt frontend #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximion
requested changes
Nov 24, 2016
| { | ||
| QList<Suggested> res; | ||
|
|
||
| auto suggestions = as_component_get_bundles(m_cpt); |
There was a problem hiding this comment.
This is certainly wrong and will explode when converting it to AsSuggested later...
| Q_ENUM(Kind) | ||
|
|
||
| Suggested(); | ||
| Suggested(_AsSuggested *icon); |
|
Also, the CI says that this code doesn't compile (and it is right). |
|
Should be okay now. |
ximion
reviewed
Nov 26, 2016
| as_suggested_add_id(d->m_suggested, qPrintable(id)); | ||
| } | ||
|
|
||
| QDebug operator<<(QDebug s, const AppStream::Suggested& image) { |
There was a problem hiding this comment.
Nitpick: Image? (also, bracked should come after a newline for functions)
ximion
approved these changes
Nov 26, 2016
|
Please do a rebase-merge or squash-merge next time to avoid pointless merge commits. |
|
Sorry, I'm not used to github UI. Will pay more attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.