Category prefixing and string constants #1

Merged
merged 4 commits into from Feb 26, 2014

Projects

None yet

2 participants

Contributor
toco commented Feb 26, 2014

I choose xngo as prefix to not clash with XNGAPIClient categories.

@pietbrauer pietbrauer commented on an outdated diff Feb 26, 2014
XNGOAuth1Client/NSDictionary+XNGOAuth1Additions.h
@@ -1,9 +1,9 @@
@interface NSDictionary (XNGOAuth1Additions)
-+ (id)dictionaryFromQueryString:(NSString *)queryString;
++ (id)xngo_dictionaryFromQueryString:(NSString *)queryString;
pietbrauer
pietbrauer Feb 26, 2014 Collaborator

We would prefer the old xng_ prefix instead of xngo_

Contributor
toco commented Feb 26, 2014

Now you have to make sure that XNGAPIClient does not contain that categories as well, but it should be fine.

Collaborator

Sure, they were included in the APIClient, I removed it. Thanks! 👾

@pietbrauer pietbrauer merged commit 740dd55 into xing:master Feb 26, 2014
Collaborator


Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment