Conversation
|
I don't fully understand what problem would be solved by renaming the gem. Some of our internal gems and also a lot of our applications depend on the the class names of this gem. They would all break. I suggest to discuss this in person on our internal slack. |
Author
|
Sorry for the delay, I haven't seen the message until now, I understood your concerns, you can ping me when you want. |
|
We plan to upgrade our fork to the latest typhoeus master by porting all patches and feature enhancements and tests. The goal is to get them merged upstream, but if this fails, we'll keep publishing our own version on our internal gem server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several gems that require a newer version of Typhoeus, renaming it will allow unblocking these dependencies.
Gems: webmock, vcr, elasticsearch-api (would work with Patreon or newer versions of Typhoeus), yabeda, avro_turf (just for testing because depending on webmock)
It is proof of concept to test the integration with other gems.
Xingfusis just a silly name, I accept suggestions.