Skip to content
Browse files

initial final code review

git-svn-id: svn+ssh://scheduler.csc.calpoly.edu/repo@2954 13b268f7-8392-4c9d-bc7d-1e80a86bc2f9
  • Loading branch information...
1 parent bdc9444 commit 22a0fea542aea26de668afc186c18dec8cb12e3e jmhand committed
Showing with 36 additions and 0 deletions.
  1. +36 −0 testing/reviews/instructor-web-app/finals-week/review_Jordan_James.html
View
36 testing/reviews/instructor-web-app/finals-week/review_Jordan_James.html
@@ -0,0 +1,36 @@
+<html>
+
+<font size=+2>
+<strong>1. Code Follows
+<a href="http://users.csc.calpoly.edu/~gfisher/classes/406/handouts/design-imple-conventions.html">
+Design and Implementation Conventions</strong>
+</a>
+</font>
+<br>Naming and code style look ok.
+<br>
+<br>
+<br>
+<font size=+2>
+<strong>2. Javadoc Is Complete and Follows Design and Implementation
+Conventions</strong>
+</font>
+<br><br>
+Implementation conventions appear to be mostly followed.<br>
+Javadoc is complete except for: InstructorDataSource.java which has none. <br>
+
+<br>
+<font size=+2>
+3. <strong>Design of the Code is Good</strong>
+</font>
+<br>
+<br>
+Design looks good.<br>
+The only thing of note was that InstructorsView has random chunks commented out.<br>
+
+<br>
+<font size=+2>
+<strong>4. Code Passes Its Tests and Has Sensible User-Level Behavior </strong>
+<br>Instructor preferences works and behaves as would be expected.<br>
+</font>
+</body>
+</html>

0 comments on commit 22a0fea

Please sign in to comment.
Something went wrong with that request. Please try again.