Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aarch64 support #156

Open
coreyjjames opened this issue Nov 4, 2019 · 6 comments · May be fixed by #183
Open

Aarch64 support #156

coreyjjames opened this issue Nov 4, 2019 · 6 comments · May be fixed by #183

Comments

@coreyjjames
Copy link

@coreyjjames coreyjjames commented Nov 4, 2019

Hello,

I am a computer programming student and for a class I am tasked with finding an open source project that I can optimize for aarch64. I found this library and noticed that you have optimized for x86_64 and PPC.
Would you be open to me adding some optimizations for Aarch64?

@erikd

This comment has been minimized.

Copy link
Member

@erikd erikd commented Nov 5, 2019

If you can hook this up and get it working then I am fine with it.

The only foreseeable problem is that it may be difficult to get CI for Aarch64.

@coreyjjames

This comment has been minimized.

Copy link
Author

@coreyjjames coreyjjames commented Nov 5, 2019

Cool, I'll see what I can do.

@petterreinholdtsen

This comment has been minimized.

Copy link

@petterreinholdtsen petterreinholdtsen commented Nov 5, 2019

@coreyjjames

This comment has been minimized.

Copy link
Author

@coreyjjames coreyjjames commented Nov 5, 2019

@petterreinholdtsen I won't be able to actively monitor the changes myself but if anyone finds a bug or something in the future you can contact me here on Github and I can take a look at it.

@NotTsunami

This comment has been minimized.

Copy link
Contributor

@NotTsunami NotTsunami commented Nov 20, 2019

If you do contribute this changes, I also recommend submitting them to the Android flac repository too, as most modern devices are using a derivative of the ARMv8 architecture (with AArch64 referring to the 64-bit state). Their Gerrit server can be found here. The Android repo appears to based off of 1.3.2 with a few cherry-picked upstream commits.

@coreyjjames

This comment has been minimized.

Copy link
Author

@coreyjjames coreyjjames commented Nov 20, 2019

@NotTsunami Sure, I can look into doing that. I should have a PR for this repo this week or the next week. I got the optimization working with my test so far, yielding about a 50% increase in speed to encoding a file on aarch64. I need to do a bit more testing, and then I can put up my PR.

@coreyjjames coreyjjames linked a pull request that will close this issue Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.