Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantizer rdo and heuristic quantizer selection causes desync #1930

Closed
ycho opened this issue Dec 9, 2019 · 1 comment
Closed

Quantizer rdo and heuristic quantizer selection causes desync #1930

ycho opened this issue Dec 9, 2019 · 1 comment

Comments

@ycho
Copy link
Collaborator

ycho commented Dec 9, 2019

Originated from #1858 and #1914.

Two commits that cause desync at speed 0,1,2 are:
3c79e02 and
db0da3c
those might cause the desync from different origins, but given that temporary fix of disabling segmentation (as in #1914) indicates that encoding of segment id might cause issue.

A set of test runs to see desync that I used can be:
./target/release/rav1e nyan.y4m -o test.ivf -r test_rec.y4m --quantizer 50 --speed=0 --limit=30
./target/release/rav1e nyan.y4m -o test.ivf -r test_rec.y4m --quantizer 50 --speed=1 --limit=30
./target/release/rav1e nyan.y4m -o test.ivf -r test_rec.y4m --quantizer 50 --speed=2 --limit=30

Note that the desync happens regardless of --tune.

@ycho
Copy link
Collaborator Author

ycho commented Dec 20, 2019

Fixed by #1977
Not merged but alternative minimum fix (for reference purpose) is:
ycho@a8f10af
in
https://github.com/ycho/rav1e/tree/3eb666a8eab_fix0

@ycho ycho closed this as completed Dec 20, 2019
Release 0.3 automation moved this from To Do to Done Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Release 0.3
  
Done
Development

No branches or pull requests

2 participants