Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the Frame-related data structures #2164

Merged
merged 6 commits into from
Feb 18, 2020
Merged

Conversation

lu-zero
Copy link
Collaborator

@lu-zero lu-zero commented Feb 10, 2020

This should make easier sharing code with the stand-alone av-scenechange and av-metrics.

  • Move Plane
    • Move the math and pixel dependencies
    • Add a copy_plane function
  • Move Frame
    • Make so the exported constructors do not depend on rav1e internals, make the rav1es use them with the internal constant.
  • Move tiling/*

v_frame/Cargo.toml Outdated Show resolved Hide resolved
@vibhoothi vibhoothi force-pushed the split-frames branch 2 times, most recently from f61c495 to d391aaf Compare February 14, 2020 12:14
src/frame/mod.rs Outdated Show resolved Hide resolved
src/frame/mod.rs Outdated Show resolved Hide resolved
src/frame/mod.rs Outdated Show resolved Hide resolved
@vibhoothi vibhoothi force-pushed the split-frames branch 2 times, most recently from 46f2758 to edec56b Compare February 17, 2020 14:48
v_frame/src/lib.rs Outdated Show resolved Hide resolved
@lu-zero
Copy link
Collaborator Author

lu-zero commented Feb 17, 2020

The tests need to be fixed.

lu-zero and others added 5 commits February 17, 2020 21:06
The plane abstraction uses it.
This commit includes:
- Moving frame's struct and impl to v_frame
- Introduction of LUMA_PADDING as a constant
- Introduction of multiple Public Trait for Frame Alocation,
  Calculating padding, new Tile of a frame
- Introduction of new video frame with padding constant as parameter
@vibhoothi
Copy link
Collaborator

Let us see now if tests are passing

Copy link
Collaborator

@shssoichiro shssoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lu-zero lu-zero removed the WorkInProgress Incomplete patchset label Feb 18, 2020
@lu-zero lu-zero merged commit 41464e7 into xiph:master Feb 18, 2020
@lu-zero lu-zero deleted the split-frames branch February 18, 2020 09:15
barrbrain pushed a commit to barrbrain/rav1e that referenced this pull request May 26, 2020
It will be used by av-metrics and av-scenechange and potentially other separate crates.

Co-authored-by: Vibhoothi <vibhoothiiaanand@gmail.com>
@vibhoothi vibhoothi mentioned this pull request Sep 15, 2020
barrbrain pushed a commit to barrbrain/rav1e that referenced this pull request Oct 5, 2022
It will be used by av-metrics and av-scenechange and potentially other separate crates.

Co-authored-by: Vibhoothi <vibhoothiiaanand@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants