-
Notifications
You must be signed in to change notification settings - Fork 280
Split the Frame-related data structures #2164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
703917c to
083b115
Compare
083b115 to
282e0f7
Compare
lu-zero
commented
Feb 12, 2020
f61c495 to
d391aaf
Compare
lu-zero
commented
Feb 14, 2020
lu-zero
commented
Feb 14, 2020
lu-zero
commented
Feb 14, 2020
46f2758 to
edec56b
Compare
shssoichiro
requested changes
Feb 17, 2020
Collaborator
Author
|
The tests need to be fixed. |
The plane abstraction uses it.
This commit includes: - Moving frame's struct and impl to v_frame - Introduction of LUMA_PADDING as a constant - Introduction of multiple Public Trait for Frame Alocation, Calculating padding, new Tile of a frame - Introduction of new video frame with padding constant as parameter
edec56b to
c547506
Compare
Collaborator
|
Let us see now if tests are passing |
shssoichiro
approved these changes
Feb 17, 2020
Collaborator
shssoichiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
barrbrain
pushed a commit
to barrbrain/rav1e
that referenced
this pull request
May 26, 2020
It will be used by av-metrics and av-scenechange and potentially other separate crates. Co-authored-by: Vibhoothi <vibhoothiiaanand@gmail.com>
Merged
barrbrain
pushed a commit
to barrbrain/rav1e
that referenced
this pull request
Oct 5, 2022
It will be used by av-metrics and av-scenechange and potentially other separate crates. Co-authored-by: Vibhoothi <vibhoothiiaanand@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make easier sharing code with the stand-alone av-scenechange and av-metrics.