Skip to content

Integrate AV-Metrics #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vibhoothi merged 1 commit into from
Mar 29, 2020
Merged

Integrate AV-Metrics #2184

vibhoothi merged 1 commit into from
Mar 29, 2020

Conversation

@vibhoothi
Copy link
Collaborator

@vibhoothi vibhoothi commented Feb 25, 2020 •
edited
Loading

This patchset introduces av-metrics to rav1e, so after encoding we can get PNSR, PSNR-HVS, CIDE2000, SSIM etc.

Things to do:

  • Adapt [WIP] Add metrics from AWCY into rav1e #1589
  • Build using rav1e
  • Fix panics
  • Test with different metrics
    • PSNR
    • PSNR-HVS
    • APSNR
    • CIEDE2000
    • SSIM
    • MS-SSIM
  • Cleanup
  • Use upsteam for
    • av-metrics
    • v-frame
  • Squash changes
  • Implement CLI alone without touching API changes

This PR Closes #1762

@rzumer rzumer added the WorkInProgress Incomplete patchset label Feb 25, 2020
lu-zero
lu-zero reviewed Feb 26, 2020
View reviewed changes
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to remove from the encoder the psnr feature and keep it only in the command line.

We should discuss it today.

lu-zero
lu-zero requested changes Feb 26, 2020
View reviewed changes
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an API breaking change, albeit small.

@vibhoothi vibhoothi force-pushed the av-metrics-2 branch 2 times, most recently from 0a20094 to 8aee1fe Compare March 6, 2020 11:53
@vibhoothi
Copy link
Collaborator Author

vibhoothi commented Mar 6, 2020 •
edited
Loading

Currently, it works without touching/calculating inside API. It is done in rav1e binary's encode_loop.

Mering depends on a few factors and PRs

Needs a clean up after the above things to be merged

@vibhoothi vibhoothi changed the title WIP: Integrate AV-Metrics Integrate AV-Metrics Mar 6, 2020
@vibhoothi vibhoothi requested a review from lu-zero March 6, 2020 15:36
vibhoothi
vibhoothi commented Mar 6, 2020
View reviewed changes
@barrbrain barrbrain removed the WorkInProgress Incomplete patchset label Mar 6, 2020
@vibhoothi vibhoothi requested a review from shssoichiro March 7, 2020 02:59
lu-zero
lu-zero requested changes Mar 8, 2020
View reviewed changes
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires some changes and some discussion.

@vibhoothi vibhoothi force-pushed the av-metrics-2 branch 4 times, most recently from c4c4df2 to a621683 Compare March 17, 2020 18:32
@vibhoothi vibhoothi requested a review from lu-zero March 18, 2020 07:28
lu-zero
lu-zero requested changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issue to address. Beside that I'm fine with it.

lu-zero
lu-zero reviewed Mar 18, 2020
View reviewed changes
@vibhoothi vibhoothi requested a review from lu-zero March 18, 2020 15:06
@vibhoothi vibhoothi force-pushed the av-metrics-2 branch 2 times, most recently from a23b6e0 to fa100d1 Compare March 18, 2020 16:32
lu-zero
lu-zero reviewed Mar 19, 2020
View reviewed changes
@vibhoothi vibhoothi requested a review from lu-zero March 19, 2020 07:54
shssoichiro
shssoichiro requested changes Mar 19, 2020
View reviewed changes
@vibhoothi vibhoothi requested a review from shssoichiro March 19, 2020 09:36
@vibhoothi vibhoothi force-pushed the av-metrics-2 branch 2 times, most recently from 8c33be2 to f449299 Compare March 19, 2020 13:50
@lu-zero
Copy link
Collaborator

lu-zero commented Mar 19, 2020

@sdroege can you confirm this is not going to break the gst plugin?

shssoichiro
shssoichiro previously requested changes Mar 19, 2020
View reviewed changes
@shssoichiro shssoichiro dismissed their stale review March 19, 2020 15:14

Changes addressed, waiting for gst review before approving

@vibhoothi vibhoothi force-pushed the av-metrics-2 branch 3 times, most recently from 0e935d1 to 3232c16 Compare March 24, 2020 21:32
@vibhoothi vibhoothi requested a review from shssoichiro March 24, 2020 21:35
shssoichiro
shssoichiro previously approved these changes Mar 25, 2020
View reviewed changes
@shssoichiro shssoichiro dismissed their stale review March 25, 2020 12:07

Bug found

@vibhoothi @shssoichiro
metrics: Calculate Metrics
a8705fb 
This commit introduces:
- Frame Metrics function to calculate
PSNR, PSNR-HVS, SSIM, MS-SSIM, CIEDE2000.
- Quality Metrics Structure to store all the calculated values
- Adding METRICS as an argument
- Updates --psnr calculation based on av-metrics
- Show calculated metrics in a neat way
- Introduce metrics_cli as an additional parameter for
process_frame as parse_cli is an expensive function to be made in
encode_loop, to make it more efficient we have moved metrics_cli
enum as an argument to process_frame and making the calculation
in do_encode function.
@sdroege
Copy link
Contributor

sdroege commented Mar 25, 2020

@sdroege can you confirm this is not going to break the gst plugin?

Compiles and tests are still passing too. Is there anything specific you want me to test otherwise?

Also don't worry about breaking API for the GStreamer plugin at least, I'm fine with updating regularly as long as you follow semver :)

lu-zero
lu-zero approved these changes Mar 29, 2020
View reviewed changes
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me as well.

@vibhoothi vibhoothi merged commit 81b25d8 into xiph:master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lu-zero lu-zero lu-zero approved these changes

@shssoichiro shssoichiro shssoichiro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate av-metrics to rav1e CLI

6 participants

@vibhoothi @lu-zero @sdroege @shssoichiro @barrbrain @rzumer