api: Introduce reference frame for Packets #2186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-zero
reviewed
Feb 28, 2020
src/api/util.rs
Outdated
| /// The reconstruction of the shown frame. | ||
| pub rec: Option<Arc<Frame<T>>>, | ||
| /// The Reference Frame | ||
| pub ref_f: Option<Arc<Frame<T>>>, |
Collaborator
There was a problem hiding this comment.
input or source might be a better name in the end.
To be discussed if Option<(Arc<Frame<T>>, Arc<Frame<T>>) wouldn't be more future proof even if it would have the problem of documenting what is what.
Collaborator
There was a problem hiding this comment.
Are you referring to putting rec and source in one element? I'm not sure that that would be cleaner/easier to reason about.
shssoichiro
approved these changes
Mar 7, 2020
lu-zero
approved these changes
Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds Reference Frame from the FrameData(Input) to the packets, so we could take this for calculation, for instance, Metrics calculations can be independent of API changes and will be cleaner to implement with fewer API breakages in favour of 1.0 Future Release.