Skip to content

Conversation

@barrbrain
Copy link
Collaborator

A similar approach is used in dav1d and this enables some improvements to the CDF log.

@coveralls
Copy link
Collaborator

coveralls commented Feb 6, 2021

Coverage Status

Coverage remained the same at 82.994% when pulling 816a7c5 on barrbrain:cdf-layout into 351f7c8 on xiph:master.

@barrbrain
Copy link
Collaborator Author

There is a change to UV_INTRA_MODES that may seem a little odd. Where the original code had UV_INTRA_MODES, it ought to read INTRA_MODES + 1 because the additional element here is the CDF counter rather than the chroma-from-luma symbol. As with other edits in this patch, we are subtracting 1 now that the trailing zero is removed. Thus UV_INTRA_MODES becomes INTRA_MODES.

The lower bits of the last symbol's value may hold the counter,
without affecting the entropy coding arithmetic.
Now the counter has moved, this position is never read nor modified.
Hoist loading the vector pointer outside the loop, as we will not
modify it while iterating.
@barrbrain barrbrain merged commit 816a7c5 into xiph:master Feb 7, 2021
@barrbrain barrbrain deleted the cdf-layout branch February 7, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants