Use explicit table lookup for ac_q and dc_q#2667
Merged
Merged
Conversation
lu-zero
requested changes
Feb 10, 2021
Collaborator
lu-zero
left a comment
lu-zero
left a comment
There was a problem hiding this comment.
Removing the & from &table should have the same effect.
barrbrain
force-pushed
the
ac-dc-lookup
branch
from
3ffbf0c to
c89c725
Compare
lu-zero
approved these changes
Feb 10, 2021
Collaborator
lu-zero
left a comment
lu-zero
left a comment
There was a problem hiding this comment.
Please change the first commit message to
Correct a misuse of pattern in a let statement
The expression required the compiler to make a copy of the array referenced
The rest looks good to land.
The original intent was a simple lookup but the expression required the compiler to make a copy of the array referenced.
Also compute the table indices such that bounds checks are elided.
barrbrain
force-pushed
the
ac-dc-lookup
branch
from
c89c725 to
784aeab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.