Tune flow of inline methods in symbol_with_update #2671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
barrbrain
commented
Feb 15, 2021
barrbrain
commented
- Mostly avoid calling Vec::reserve() in CDFContextLogOps::push().
- Manually elide bounds checks in WriterBase::symbol() as they are not easily inferred by the compiler although statically known.
- Rewrite ec::rust::update_cdf() to be panic-free and hint to the compiler not to unroll beyond the maximum CDF length.
lu-zero
approved these changes
Feb 15, 2021
| @@ -524,9 +524,12 @@ where | |||
| #[inline(always)] | |||
| fn symbol(&mut self, s: u32, cdf: &[u16]) { | |||
There was a problem hiding this comment.
Add a TODO: rewrite once const generics are stable
There was a problem hiding this comment.
Isn't the scope of rewriting using const generics much broader than this function?
There was a problem hiding this comment.
yes, but this is one that would be good to not forget :)
src/ec.rs
Outdated
| // Single loop (faster) | ||
| for (i, v) in cdf[..nsymbs - 1].iter_mut().enumerate() { | ||
| for (i, v) in cdf[..nsymbs - 1].iter_mut().enumerate().take(15) { |
There was a problem hiding this comment.
15 shouldn't be expressed using Self::CDF_LEN_MAX ?
There was a problem hiding this comment.
Self::CDF_LEN_MAX is defined for CDFContextLogOps rather than WriterBase. We could reference context::CDF_LEN_MAX after making it accessible.
There was a problem hiding this comment.
Probably it would be good or having ec::CDF_LEN_MAX defined.
* Mostly avoid calling Vec::reserve() in CDFContextLogOps::push(). * Manually elide bounds checks in WriterBase::symbol() as they are not easily inferred by the compiler although statically known. * Rewrite ec::rust::update_cdf() to be panic-free and hint to the compiler not to unroll beyond the maximum CDF length.
barrbrain
force-pushed
the
ec-no-panic
branch
from
ca324e7 to
e9be6c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.