Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CDF access so that size is always statically known #2673

merged 10 commits into from Feb 18, 2021


Copy link

@barrbrain barrbrain commented Feb 16, 2021

While removing explicit slices for CDF access, it was shown that some were not ordered by size in CDFContext. This violates the invariant introduced in PR #2664, to guarantee non-overlapping writes at rollback. This change ensures that the invariant holds.
As the CDF expressions passed to symbol_with_update! all become mutable references to arrays, we can specialise symbol_with_update() for small numbers of CDF symbols. This yields a speed-up on the order of 1.5%.

Copy link

coveralls commented Feb 16, 2021

Coverage Status

Coverage decreased (-0.06%) to 82.945% when pulling 33f31e7 on barrbrain:cdf-static-size into e9be6c9 on xiph:master.

@barrbrain barrbrain force-pushed the cdf-static-size branch 2 times, most recently from 7202631 to 6b3b63a Compare February 16, 2021 15:55
@barrbrain barrbrain marked this pull request as ready for review February 16, 2021 16:10
Copy link

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@barrbrain barrbrain merged commit 33f31e7 into xiph:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants