Refactor CDF access so that size is always statically known #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrbrain
force-pushed
the
cdf-static-size
branch
2 times, most recently
from
7202631
to
6b3b63a
Compare
barrbrain
commented
Feb 16, 2021
barrbrain
force-pushed
the
cdf-static-size
branch
from
6b3b63a
to
1485720
Compare
barrbrain
force-pushed
the
cdf-static-size
branch
from
1485720
to
d8f26bc
Compare
barrbrain
force-pushed
the
cdf-static-size
branch
from
e4344a2
to
9f48d4a
Compare
barrbrain
force-pushed
the
cdf-static-size
branch
from
9f48d4a
to
33f31e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While removing explicit slices for CDF access, it was shown that some were not ordered by size in
CDFContext. This violates the invariant introduced in PR #2664, to guarantee non-overlapping writes at rollback. This change ensures that the invariant holds.As the CDF expressions passed to
symbol_with_update!all become mutable references to arrays, we can specialisesymbol_with_update()for small numbers of CDF symbols. This yields a speed-up on the order of 1.5%.