Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: publicUrl/3 reverses paths of development mode and production mode #415

Closed
ngocdaothanh opened this issue Jun 16, 2014 · 2 comments
Closed

Fix: publicUrl/3 reverses paths of development mode and production mode #415

ngocdaothanh opened this issue Jun 16, 2014 · 2 comments
Assignees
@ngocdaothanh
Labels
Bug
Milestone
Xitrum 3.15

Comments

@ngocdaothanh
Copy link
Member

Current code:

def publicUrl(directory: String, devPath: String, prodPath: String): String = {
  val path1 = if (Config.productionMode) devPath else prodPath
  val path2 = s"$directory/$path1"
  publicUrl(path2)
}
@ngocdaothanh ngocdaothanh added this to the Xitrum 3.15 milestone Jun 16, 2014
@ngocdaothanh ngocdaothanh self-assigned this Jun 16, 2014
@ngocdaothanh
Copy link
Member Author

Also add publicUrl/2.

@ngocdaothanh
Copy link
Member Author

See 8c1ce34

ngocdaothanh added a commit that referenced this issue Jul 3, 2014
@ngocdaothanh
Update CHANGELOG about #415
1f21236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngocdaothanh ngocdaothanh

Labels
Bug
Projects
None yet
Milestone
Xitrum 3.15
Development

No branches or pull requests
1 participant
@ngocdaothanh