Add config maxHeaderSize (for the entire HTTP header, defaults to 8192) #512

Closed
caiiiycuk opened this Issue Feb 6, 2015 · 5 comments

Projects

None yet

3 participants

@caiiiycuk
Contributor

Hi again!

Search engines (like google or yandex) adds a Referer header to request. Sometimes (in our case) this header can exceed the maximum HTTP header length and in this case server drops the connection. We need way to configure this option (to increase maximum header length).

It will be good if we can configure this options in xitrum.conf, like in play framework:
https://www.playframework.com/documentation/2.3.x/ProductionConfiguration

@caiiiycuk
Contributor

UPD: In the link above please goes to "Advanced HTTP server configuration" section.

@ngocdaothanh ngocdaothanh added this to the Xitrum 3.23 milestone Feb 6, 2015
@georgeOsdDev
Member
The maximum length of all headers. If the sum of the length of each header exceeds this value, a TooLongFrameException will be raised.

When TooLongFrameException(DecoderException) was thrown, it will be caught at BadClientSilencer.
Should we respond 400?

@ngocdaothanh
Member

Because this exception is thrown from a handler to other handlers in the pipeline, I think it's the only good place where we can catch the exception. I guess there's no better place.

@georgeOsdDev georgeOsdDev added a commit to georgeOsdDev/xitrum that referenced this issue Feb 10, 2015
@georgeOsdDev georgeOsdDev PR for #512 Feature request: needed more control over netty configura…
…tion
ae6c841
@georgeOsdDev georgeOsdDev added a commit to georgeOsdDev/xitrum that referenced this issue Feb 10, 2015
@georgeOsdDev georgeOsdDev PR for #512 Feature request: needed more control over netty configura…
…tion
32b3503
@ngocdaothanh ngocdaothanh changed the title from Feature request: needed more control over netty configuration to Add config maxHeaderSize (maximum size for the entire HTTP header, defaults to 8192) Feb 10, 2015
@ngocdaothanh ngocdaothanh changed the title from Add config maxHeaderSize (maximum size for the entire HTTP header, defaults to 8192) to Add config maxHeaderSize (for the entire HTTP header, defaults to 8192) Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment