Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing search options #3

Merged
merged 3 commits into from Sep 15, 2018
Merged

Conversation

@hatt
Copy link
Contributor

hatt commented Sep 15, 2018

Move column to be global, and add tags. Tags doesn't validate the string format, but the documentation includes a link to the GH issue tracking string validation in TypeScript.

ayyaruq added 3 commits Sep 15, 2018
@ayyaruq

This comment has been minimized.

Copy link
Contributor

ayyaruq commented Sep 15, 2018

MFW people using my laptop and don't sign out of their own GitHub :blobshake:

@viion
viion approved these changes Sep 15, 2018
Copy link

viion left a comment

Great!

@Supamiu

This comment has been minimized.

Copy link
Collaborator

Supamiu commented Sep 15, 2018

Please consider following the commit conventions next PR to make sure changelog gets everything right :) I'm going to squash it to one commit but it means one changelog entry only.

@Supamiu Supamiu merged commit a902fda into xivapi:master Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.