Skip to content

Cleaned up errors to be more precise. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Conversation

Andrew-Cha
Copy link
Contributor

They now specify the place where it happens (due to the nature of JS being wonky, I feel like this would help with debugging).

Also follow a correct grammatical sentence structure - capitalization etc.

@kaimoe
Copy link
Member

kaimoe commented Mar 26, 2019

Thanks! Just one concern: I disagree with changing the case of parameters in favor of proper grammar, since I think that'd make the error slightly more complicated to amend (having an error mention The ID of __ when the actual property is id, all lowercase, might be confusing).

Just going to change that, but otherwise, looks good!

@kaimoe kaimoe merged commit bdd8e88 into xivapi:master Mar 26, 2019
@Andrew-Cha
Copy link
Contributor Author

Sounds good

Andrew-Cha added a commit to Andrew-Cha/xivapi-js that referenced this pull request Apr 3, 2019
The Int parsing bug was reported by @soujixivapi#1 and Vekien on Discord.

The error was:
ID `9233364398528114605`
gets parsed into
ID `9233364398528115000`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants