From 1e83f306688e939fe4f1193c35b3a3ef8f1b8c8b Mon Sep 17 00:00:00 2001 From: Cammy <52957759+c0reme@users.noreply.github.com> Date: Thu, 30 Oct 2025 11:11:56 +0000 Subject: [PATCH 1/2] chore: add build step Add build step before publishing to npm --- .github/workflows/npm-publish.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index dfe4d70..43919bd 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -17,6 +17,7 @@ jobs: node-version: '24.x' registry-url: 'https://registry.npmjs.org' - run: npm ci + - run: npm run build - run: npm publish --provenance --access public env: NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} From 7c12e96f831d7e3671718e0f995b935cad8b7036 Mon Sep 17 00:00:00 2001 From: c0reme Date: Thu, 30 Oct 2025 11:34:05 +0000 Subject: [PATCH 2/2] fix: ensure params are correctly typed in asset requests --- src/lib/assets.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/assets.ts b/src/lib/assets.ts index f1973b4..b3af79e 100644 --- a/src/lib/assets.ts +++ b/src/lib/assets.ts @@ -13,7 +13,7 @@ export class Assets { * @see https://v2.xivapi.com/api/docs#tag/assets/get/asset */ async get(params: Models.AssetQuery): Promise { - const { data, errors } = await request({ path: "/asset", params }) + const { data, errors } = await request({ path: "/asset", params: params as unknown as Record }) if (errors) throw new CustomError(errors[0].message) return data as Buffer } @@ -27,7 +27,7 @@ export class Assets { async map( params: Models.MapPath & Models.VersionQuery & Pick ): Promise { - const { data, errors } = await request({ path: "/asset/map", params }) + const { data, errors } = await request({ path: "/asset/map", params: params as unknown as Record }) if (errors) throw new CustomError(errors[0].message) return data as Buffer }