Repository navigation
Fix some interactive wayland bits - #900
Merged
Merged
Conversation
Previously we would try to commit an incomplete xdg_surface. This is illegal in xdg_shell and results in a "not constructed" xdg_wm_base error. Shift the ifdef's around a bit so that only the actually relevant code for the keymap-dump utility is compiled.
Let's make sure we destroy our wayland resource objects in a nice order to avoid any errors at shutdown time. Fixes errors like: $ xkbcli interactive-wayland [...] [destroyed object]: error 6: surface was destroyed before its role object
wismill
added
bug
Member
|
Great fixes! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xkbcli keymap-dumpwas kinda broken on wayland because it would commit an xdg surface without a role object. Applies some small fixes to the wayland code.