Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode input characters and encode output using provided Charset #34

Merged
merged 5 commits into from
May 26, 2020

Conversation

MikeEdgar
Copy link
Member

Fixes #33

Calling flush() (or close()) on the EDIStreamWriter is critical with this change due to the buffer used by OutputStreamWriter.

@MikeEdgar MikeEdgar added this to the v1.7.0 milestone May 25, 2020
@coveralls
Copy link

coveralls commented May 25, 2020

Pull Request Test Coverage Report for Build 115250475

  • 59 of 62 (95.16%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 95.287%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/io/xlate/edi/internal/stream/tokenization/Lexer.java 35 36 97.22%
src/main/java/io/xlate/edi/internal/stream/StaEDIStreamWriter.java 10 12 83.33%
Totals Coverage Status
Change from base Build 112952905: 0.07%
Covered Lines: 3700
Relevant Lines: 3883

💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

96.0% 96.0% Coverage
0.0% 0.0% Duplication

@MikeEdgar MikeEdgar merged commit 3553273 into master May 26, 2020
@MikeEdgar MikeEdgar deleted the 33_correct_charset_handling branch May 26, 2020 01:17
@MikeEdgar
Copy link
Member Author

@ChrisPaprocki - these changes should be release later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-ASCII input and output are not properly handled
2 participants