Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular V8.3 #327

Closed
Jefiozie opened this issue Oct 11, 2019 · 6 comments
Closed

Upgrade to Angular V8.3 #327

Jefiozie opened this issue Oct 11, 2019 · 6 comments

Comments

@Jefiozie
Copy link
Member

@Jefiozie Jefiozie commented Oct 11, 2019

We would like to be on the latest Angular version. This means that we should update xlayers and the dependencies like ngxs.

As the most of our code is Angular, it will be easy to do the upgrade by using the 'ng update' command from the cli.

@kartik-budhiraja

This comment has been minimized.

Copy link
Contributor

@kartik-budhiraja kartik-budhiraja commented Oct 17, 2019

@Jefiozie I would like to work on this issue if it's available.

@Jefiozie

This comment has been minimized.

Copy link
Member Author

@Jefiozie Jefiozie commented Oct 17, 2019

Hi @kartik-budhiraja, thank you for replying, you can work on it if you want. If you need any help just leave a comment and I will do my best to help you.

@kartik-budhiraja

This comment has been minimized.

Copy link
Contributor

@kartik-budhiraja kartik-budhiraja commented Oct 19, 2019

@Jefiozie We are aiming to upgrade only angular modules like CDK, cli, core, or are we aiming to upgrade every dependency which has a newer version?

@Jefiozie

This comment has been minimized.

Copy link
Member Author

@Jefiozie Jefiozie commented Oct 19, 2019

@kartik-budhiraja our main focus should be on the Angular and dependencies that relate to the @angular/core. For example @ngxs/store is depending on @angular/core so probably we should upgrade this as well.

The angular package can be easily upgraded by using the ng update <package> command. The others probably need some manual upgrades.

kartik-budhiraja added a commit to kartik-budhiraja/xlayers that referenced this issue Oct 20, 2019
upgrade core Angular and other dependencies

xlayers#327
@kartik-budhiraja kartik-budhiraja mentioned this issue Oct 20, 2019
2 of 12 tasks complete
@kartik-budhiraja

This comment has been minimized.

Copy link
Contributor

@kartik-budhiraja kartik-budhiraja commented Oct 20, 2019

@Jefiozie ng update <package> command currently has a bug where it updates rest of the dependencies to beta versions, according to this comment updating dependencies manually in package.json has been suggested. I created a PR #332 with the changes.

@Jefiozie

This comment has been minimized.

Copy link
Member Author

@Jefiozie Jefiozie commented Oct 21, 2019

Thanks for helping us with this issue and thanks for having a look at the reason ng update command did not work. Already reviewed your PR and it looks good! Thank you 🙏🏻

@Jefiozie Jefiozie moved this from To do to In progress in xLayers on NPM Nov 4, 2019
Jefiozie added a commit that referenced this issue Nov 5, 2019
upgrade core Angular and other dependencies

#327
@Jefiozie Jefiozie closed this Nov 5, 2019
@Jefiozie Jefiozie moved this from In progress to Done in xLayers on NPM Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.