Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneDrive Path #1253

Closed
jaymegordo opened this issue Feb 6, 2020 · 13 comments · Fixed by #1258
Closed

OneDrive Path #1253

jaymegordo opened this issue Feb 6, 2020 · 13 comments · Fixed by #1258
Labels
Milestone

Comments

@jaymegordo
Copy link

Mac Catalina
0.17.1, Office 365, Python 3.8

Describe your issue (incl. Traceback!)

(Similar to #1069 and #215)
When the excel file is saved in OneDrive, ThisWorkbook.FullPath returns a UNC path like:
https://d.docs.live.net/4ffb1cf57289ab33/myproject
instead of:
/users/john/onedrive/myproject

Side issue - the VBA function ToPosixPath() swaps the / and : and converts this to: /https/::d.docs.live.net:4ffb1cf57289ab33:myproject

Even if the OneDrive path was converted correctly it still wouldn't work though, which is the real issue.

This seems to have been resolved for windows (as per #215), but not mac yet?

Not a major issue, can just hard code the path for now, but wanted to raise it just in case anyone else has same issue or knows a fix.

@fzumstein
Copy link
Member

yes, the fix was only for windows...

@fzumstein fzumstein changed the title Mac OneDrive Path OneDrive Path Feb 13, 2020
@fzumstein
Copy link
Member

Actually, I hear it may not have been solved on Windows neither (may have only been the SharePoint version).

@fzumstein fzumstein added the bug label Feb 13, 2020
@fzumstein fzumstein added this to the 0.17.2 milestone Feb 13, 2020
@GregSal
Copy link

GregSal commented Mar 14, 2020

I am using xlwings V0.18.0. I was not having any issues until Windows 10 updates (KB4551762 & KB4541338) were applied this week.
It appears that these updates have broken the fix. I am able to get it working by switching from OneDrive to DropBox. Based on other spreadsheet link behaviour, this appears to be Windows Bug not an xlwings bug because it is complaining about links between spreadsheets as well. I haven't tried rolling back the update yet, because I can do that at home but not at work.

@fzumstein
Copy link
Member

What issue do you see exactly?

@GregSal
Copy link

GregSal commented Mar 14, 2020 via email

@fzumstein
Copy link
Member

Looks like there are some cases where it still breaks. Can you try to use xw.Book() instead of xw.books.open() and see if that works?

@fzumstein
Copy link
Member

Actually, you'd need to have the spreadsheet open first (just for testing).

@Coemgenus
Copy link

Coemgenus commented Mar 18, 2020

Hello,

I have the same issue since the last Windows Update this week.

It works perfectly fine outside OneDrive, but as soon as i'm using oneDrive files, xlwings addin doesn't work properly and cannot recognize my folder path.

For exemple the Addin "Run Main" button is not working because it can't find the proper module name in its path.

I'm working outside onedrive waiting for a fix.

Take care of you

@fzumstein
Copy link
Member

fzumstein commented Mar 18, 2020

Can you add the folder of where your module is to the PYTHONPATH in the addin? let me know if that works then

@Coemgenus
Copy link

Yes, this is working when i add the folder in the PYTHONPATH.

This is a good temporary fix, i'll be able to sync my data with onedrive.

Thankyou

@fzumstein
Copy link
Member

You can also set the PYTHONPATH to %ONEDRIVE%\yourproject - that way it's slightly more flexible.

@Coemgenus
Copy link

I will do that, thanks again for your precious help!

@fzumstein
Copy link
Member

see also: #1275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants