Skip to content

reports: refactor filters #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fzumstein opened this issue Jul 24, 2021 · 0 comments · Fixed by #1679
Closed

reports: refactor filters #1675

fzumstein opened this issue Jul 24, 2021 · 0 comments · Fixed by #1679
Labels
PRO Refactoring
Milestone
0.24.4

Comments

@fzumstein
Copy link
Member

Turn them into proper filters that respect the order in which they are called
@fzumstein fzumstein added this to the 0.24.5 milestone Jul 24, 2021
@fzumstein fzumstein added the PRO label Jul 24, 2021
@fzumstein fzumstein modified the milestones: 0.24.5, 0.24.4 Jul 25, 2021
fzumstein added a commit that referenced this issue Jul 25, 2021
@fzumstein
refactored filters to be called according to their position dependent…
c416bd8 
… and allow them to be called multiple times. Closes #1675
fzumstein added a commit that referenced this issue Jul 25, 2021
@fzumstein
refactored filters to be called according to their position dependent…
4507887 
… and allow them to be called multiple times. Closes #1675
fzumstein added a commit that referenced this issue Jul 25, 2021
@fzumstein
refactored filters to be called according to their position dependent…
32cec2e 
… and allow them to be called multiple times. Closes #1675
@fzumstein fzumstein mentioned this issue Jul 25, 2021
Merged
fzumstein added a commit that referenced this issue Jul 25, 2021
@fzumstein
refactored filters to be called according to their position dependent…
3f09dd6 
… and allow them to be called multiple times. Closes #1675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PRO Refactoring
Projects
None yet
Milestone
0.24.4
Development

Successfully merging a pull request may close this issue.

reports: refactored filters xlwings/xlwings
1 participant
@fzumstein