Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate create_report in favor of render_template and expose it on book, too #1738

Closed
fzumstein opened this issue Oct 19, 2021 · 0 comments · Fixed by #1747
Closed

deprecate create_report in favor of render_template and expose it on book, too #1738

fzumstein opened this issue Oct 19, 2021 · 0 comments · Fixed by #1747
Milestone

Comments

@fzumstein
Copy link
Member

Current situation:

xw.pro.reports.create_report()
myapp.create_report()
mysheet.render_template()

Suggestion:

xw.pro.reports.render_template()  # same as next line, but doesn't require to start with an app object
myapp.render_template()  # copies template book, then renders all sheets in copied book
mybook.render_template()  # renders all sheets in book
mysheet.render_template()  # renders single sheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant