bug if PYTHONPATH contains multiple directories

[sdementen]

If PYTHONPATH contains multiple directories separated by ";" the RunCommand is not correct.

    RunCommand = "python -c ""import sys; sys.path.append(r'" & PYTHONPATH & "'); " & Command & """ "

can be replaced by

    RunCommand = "python -c ""import sys; sys.path.extend(r'" & PYTHONPATH & ".split(";")'); " & Command & """ "

[sdementen]

Hello Felix, I did a PR for both issues 258 and 257. I am not familiar yet with PRs, did I do that correctly ? Do I need to do an extra step ?

[fzumstein]

Regarding the PRs, there's nothing really wrong, but I still have the following inputs:

• Name PRs according to what they to, i.e Added app property rather than proposal for issue #253
• Same goes for the underlying branch, better to name it app-property than something like patch1 - but I think you've already done that in the more recent PRs
• If possible and if it makes sense, add a unit test

[fzumstein]

Just noticed now that this has to be fixed for Mac and OptimizedConnection also

[fzumstein]

Fixed by 93cd8f6

[xkeecs]

did a google search and found this solution. so in the new version we can separate multiple python path by ";". I think it's better to change the docs: http://docs.xlwings.org/en/stable/addin.html here to make the description of PYTHONPATH consistent with UDF_MODULES.