Catch getmtime errors during module reload #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added a change to include mybook.zip by default in the pythonpath: https://app.xltrail.com/#/workbook/github.com%2FZoomerAnalytics%2Fxlwings.git%2Fxlwings%2Faddin%2Fxlwings.xlam/diff/32b8d8dc020a1d302df4e9809143e6e33b46d33c/7b3425a4f365487b40098d5740d1df131a8110c3?public=true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On first loading of a module, this catches any errors generated using
getmtime()and setsfiletimetoNone. On subsequent reloads it checksfiletimeto see if it'sNone, and if it is we assume that the file cannot change and thus does not need to reload.This does not fix
Import UDFsin all cases (as that can break for other reasons), but it does allow the packaging of a module into a zip file for distribution, and not have xlwings immediately crash when it tries to run anything.There should be no detrimental effect to current functionality.