Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to install xlwings on Linux by setting env var #1052

Merged
merged 1 commit into from Mar 17, 2019

Conversation

Projects
None yet
2 participants
@fzumstein
Copy link
Member

fzumstein commented Mar 17, 2019

See #1051 for use case

@fzumstein fzumstein merged commit da9f588 into master Mar 17, 2019

1 check passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@fzumstein fzumstein added this to the 0.15.4 milestone Mar 17, 2019

@SimonBiggs

This comment has been minimized.

Copy link

SimonBiggs commented Mar 17, 2019

Thank you so much for this

@SimonBiggs

This comment has been minimized.

Copy link

SimonBiggs commented Apr 1, 2019

I'm attempting to have this not impede on pymedphys installation workflow. Within my setup.py I am running os.system("export INSTALL_ON_LINUX=1") (pymedphys/pymedphys@978ba3f) to meet this constraint. However, unfortunately this line of code will not run if PyMedPhys is installed via a wheel. See:

https://stackoverflow.com/questions/54467648/python-setup-py-set-environment-variable-prior-to-running-install-requires

So unfortunately this does have an unfortunate flow on effect for packages that want to depend on xlwings.

Is there potential to instead have this be a user warning of some sort as opposed to a hard "will not install without environment variable". Sorry to be a bit of a pain :/ I'll try think of a neat solution if I can.

@SimonBiggs

This comment has been minimized.

Copy link

SimonBiggs commented Apr 1, 2019

Potentially, might it be possible to not raise this flag if xlwings is being installed as a result of being contained within install_requires?

As in, if the user is manually trying to install xlwings themselves, then sure, raise this error without an environment variable. But if another package is requesting installation, can it be allowed to go ahead?

@fzumstein

This comment has been minimized.

Copy link
Member Author

fzumstein commented Apr 1, 2019

why can't you set the environment variable before installing pymedphys? from what I understand your use case is to make this work on a Linux based CI.

export INSTALL_ON_LINUX=1
pip install pymedphys
@SimonBiggs

This comment has been minimized.

Copy link

SimonBiggs commented Apr 1, 2019

@fzumstein

This comment has been minimized.

Copy link
Member Author

fzumstein commented Apr 1, 2019

do your users need xlwings when they install pymedphys on linux? if not, simply take out xlwings as dependency on linux.

@SimonBiggs

This comment has been minimized.

Copy link

SimonBiggs commented Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.