Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: conflict on how python and sqlite3 interpret the apostrophe #1102

Merged
merged 1 commit into from Aug 11, 2019

Conversation

@atallaashraf
Copy link
Contributor

commented May 15, 2019

This is to fix a bug that shows up when the excel cell has both (") and (')

example: if cell contains the following text: X"Y'Z then sql.py will try to execute an INSERT statement with X"Y'Z which is not understood by sqlite3 and causes an error.

By replacing every ' instant by '' the statement error will be solved

Bug Fix: conflict on how python and sqlite3 interpret the apostrophe
This is to fix a bug that shows up when the excel cell has both (") and (')
@fzumstein

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

thanks - I'll try to review soon, sorry for the delay!

@fzumstein fzumstein merged commit 647e05b into xlwings:master Aug 11, 2019

@fzumstein fzumstein added this to the 0.15.9 milestone Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.