Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for path-like objects in API #1126

Merged
merged 2 commits into from Aug 10, 2019

Conversation

@zoquda
Copy link
Contributor

commented Jun 25, 2019

This pull request adds support for path-like objects (available in python 3.6 and higher) to API input arguments. It should now be possible for users to provide any object that is an instance of os.PathLike (which includes pathlib.Path objects) as path argument.

The changes made basically amount to ensuring that any path-like object is converted to a string object at the earliest opportunity.

Included as well are some new unit tests with pathlib.Path objects.

Closes: #1124

zoquda added 2 commits Jun 25, 2019
Add support for path-like objects in API
Previously all path input arguments had to be a string object. Path
input arguments now accept any object that is an instance of
`os.PathLike` as well.

Closes: #1124
@zoquda

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

May I ask what the assessment of this pull request is?

@fzumstein

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

sorry for the delay! I should have time soon to get to it!

@fzumstein fzumstein added this to the 0.15.9 milestone Aug 10, 2019

@fzumstein fzumstein merged commit 18236cd into xlwings:master Aug 10, 2019

@zoquda zoquda deleted the zoquda:pathlike-support branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.