Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UDF import fallback to prevent unreproducible Automation error 440 #1381

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

fzumstein
Copy link
Member

…error 440

@fzumstein fzumstein added this to the 0.20.2 milestone Aug 10, 2020
@Colin-b
Copy link
Contributor

Colin-b commented Aug 10, 2020

Won't this change make it impossible for other application to have their own version of xlwings ? I mean, I personally use another xlam with its own xlwings_udfs. This change will not allow that anymore, as it will require the xlam to be named as xlwings. Or am I mistaken ?

@fzumstein
Copy link
Member Author

better now?

@Colin-b
Copy link
Contributor

Colin-b commented Aug 10, 2020

It's better, but I don't know how it will behave if the user have xlwings addin installed, and another xlam "embedding" xlwings ? Not so sure how it would behave right now so I guess it's ok :-)

@fzumstein fzumstein changed the title Refactored UDF import mechanism to prevent unreproducable Automation … Added UDF import fallback to prevent unreproducable Automation error 440 Aug 10, 2020
@fzumstein
Copy link
Member Author

fzumstein commented Aug 10, 2020

should be good now

@fzumstein fzumstein merged commit 9b43886 into master Aug 10, 2020
@fzumstein fzumstein changed the title Added UDF import fallback to prevent unreproducable Automation error 440 Added UDF import fallback to prevent unreproducible Automation error 440 Aug 10, 2020
@fzumstein fzumstein deleted the import-udfs-refactor branch August 13, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants