Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent zombie processes after running app.quit() #1397

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

fzumstein
Copy link
Member

Currently, running the following leaves a zombie process:

>>> app = xw.App()
>>> app.quit()

This is only cleaned up after properly quitting the python process, leaving it around hanging forever if e.g. the command prompt is closed directly.

@fzumstein fzumstein added the bug label Aug 26, 2020
@fzumstein fzumstein added this to the 0.20.5 milestone Aug 26, 2020
@fzumstein fzumstein merged commit fa6018a into master Aug 26, 2020
@fzumstein fzumstein deleted the cleanup-app-when-quitting branch August 28, 2020 23:01
@wkschwartz
Copy link
Contributor

The changelog for this item links #1396 instead of #1397

@fzumstein
Copy link
Member Author

@wkschwartz, fixed, thanks!

@czluo
Copy link

czluo commented Dec 1, 2020

I am using xlWings Version: 0.20.8. I ran the code above and found that the zoombie process still existed. I have to run "app.kill()" instead to end the process. Is this problem coming up again?

@fzumstein
Copy link
Member Author

please open an issue with a code sample to replicate.

gdementen added a commit to gdementen/larray that referenced this pull request Jun 29, 2021
Happened at the end of a pytest run. IIRC, this was done this way because of a bug in xlwings which left it open.
It seems fixed now (from 0.20.5 - Aug 27, 2020 onward). See xlwings/xlwings#1397
gdementen added a commit to gdementen/larray that referenced this pull request Jul 29, 2021
Happened at the end of a pytest run. IIRC, this was done this way because of a bug in xlwings which left it open.
It seems fixed now (from 0.20.5 - Aug 27, 2020 onward). See xlwings/xlwings#1397
gdementen added a commit to larray-project/larray that referenced this pull request Jul 29, 2021
Happened at the end of a pytest run. IIRC, this was done this way because of a bug in xlwings which left it open.
It seems fixed now (from 0.20.5 - Aug 27, 2020 onward). See xlwings/xlwings#1397
alixdamman pushed a commit to alixdamman/larray that referenced this pull request Aug 10, 2021
Happened at the end of a pytest run. IIRC, this was done this way because of a bug in xlwings which left it open.
It seems fixed now (from 0.20.5 - Aug 27, 2020 onward). See xlwings/xlwings#1397
alixdamman pushed a commit to alixdamman/larray that referenced this pull request Aug 17, 2021
Happened at the end of a pytest run. IIRC, this was done this way because of a bug in xlwings which left it open.
It seems fixed now (from 0.20.5 - Aug 27, 2020 onward). See xlwings/xlwings#1397
gdementen added a commit to gdementen/larray that referenced this pull request Nov 30, 2021
Happened at the end of a pytest run. IIRC, this was done this way because of a bug in xlwings which left it open.
It seems fixed now (from 0.20.5 - Aug 27, 2020 onward). See xlwings/xlwings#1397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants