Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader: turn ints to float and let pyo3 handle datetime #2066

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Reader: turn ints to float and let pyo3 handle datetime #2066

merged 1 commit into from
Oct 20, 2022

Conversation

fzumstein
Copy link
Member

  • Turn ints to floats to be in line with the interactive (COM/appscript) behavior
  • Let pyo3 handle DateTime conversion (added with pyo3 0.17.2)

@fzumstein fzumstein added this to the 0.28.3 milestone Oct 20, 2022
@fzumstein fzumstein merged commit acc37ba into main Oct 20, 2022
@fzumstein fzumstein deleted the reader-int-to-floats branch October 20, 2022 20:34
@fzumstein fzumstein added the PRO label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug engine: reader [calamine] PRO
Projects
None yet
Milestone
0.28.3
Development

Successfully merging this pull request may close these issues.
1 participant
@fzumstein