Read config from (optional) xlwings.conf in workbook's directory #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, will try to merge/release soon, thanks! |
|
Now that the add-in is version controlled using xltrail, how should PRs be submitted for VBA code? Should I create a PR with xlwings.xlam ? And how abt. the _standalone.xlsm workbooks, are they handled by the build process? |
|
We didnt' have any automatic merging in place pre xltrail neither, I will need to do some manual work. So your PR is still fine, apologies for the slowliness in merging. the standalone files are built by https://github.com/ZoomerAnalytics/xlwings/blob/master/scripts/build_standalone_files.py so these are fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current config system is:
The code in the PR modifies the config system:
I have a scenario where a xlwings-powered workbook should be deployed to a Citrix environment. This change makes it easier to deploy a package w/ the workbook on the environment. With this change, the automated deployment system can simply create a text file in the workbook's directory.
(contrast without the change: Either make sure all users have ~/xlwings.conf file in their home directories, or use COM automation to modify contents of the workbook's xlwings.conf)