valijson: add package

[star-hengxing]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @star-hengxing, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the valijson library, a header-only C++ solution for JSON Schema validation, into the project's package management system. It provides necessary build configurations, including an option to control exception handling, and includes a basic test to ensure proper functionality and C++14 compatibility.

Highlights

• New Package Addition: Introduces valijson, a header-only C++ library for JSON Schema validation, into the package ecosystem.
• Configuration Options: Adds an exceptions configuration option, allowing users to enable or disable exception handling within the valijson library.
• Build and Test Integration: Includes cmake as a dependency and provides an on_install script to configure the build process, along with an on_test snippet to verify successful integration and basic functionality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a new package for the valijson header-only library. My review identifies two main issues. First, the package as submitted is not functional because it lacks a required JSON parser adapter configuration. Second, the installation logic uses CMake, which is inefficient and unconventional for a header-only library in Xmake. I've provided suggestions to add rapidjson as a default adapter, simplify the installation to a direct file copy, and improve the test snippet to verify the adapter integration.

[gemini-code-assist]

There are two issues with the current package definition:

1. Missing Parser Adapter: valijson requires a JSON parser adapter to be functional. Without one, it's not possible to validate any JSON documents. The package should configure a default adapter.
2. Inefficient Installation: For a header-only library, using cmake for installation is unnecessary. The idiomatic approach in Xmake is to copy the header files directly using os.cp.

The suggested change addresses both points by adding rapidjson as a dependency and default adapter, and simplifying the on_install function. This makes the package functional and more efficient, while also removing the unneeded cmake dependency.

    add_configs("exceptions", {description = "Enable exception", default = true, type = "boolean"})

    add_deps("rapidjson")

    on_install(function (package)
        if package:config("exceptions") then
            package:add("defines", "VALIJSON_USE_EXCEPTIONS=1")
        end

        package:add("defines", "VALIJSON_ADAPTER_RAPIDJSON")
        os.cp("include/valijson", package:installdir("include"))
    end)