Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt generator do not use precompiled headers feature of CMake #1819

Closed
TNtube opened this issue Nov 8, 2021 · 2 comments
Closed

Comments

@TNtube
Copy link

TNtube commented Nov 8, 2021

Describe the bug

I use xmake in CLion, so I use the CMakeLists generator given by xmake to compile my project using CMake on CLion.
But I noticed that when I'm using precompiled headers in my xmake.lua with the line
set_pcxxheader("Cardia/include/cdpch.hpp"), it doesn't translate it in cmake.

Expected behavior

Find in the CMakeLists.txt generated

target_precompile_headers(Cardia
  PUBLIC
    cdpch.hpp
)

Error output

No error, just an unexpected behavior

Related Environment

  • xmake version: xmake v2.5.9+dev.66c32d141
  • os: Windows
  • target platform: Windows
@TNtube TNtube added the bug label Nov 8, 2021
@waruqi waruqi added improvement and removed bug labels Nov 8, 2021
@waruqi waruqi added this to the v2.6.1 milestone Nov 8, 2021
@waruqi
Copy link
Member

waruqi commented Nov 8, 2021

I have added it. dd91627

@TNtube
Copy link
Author

TNtube commented Nov 8, 2021

Thank you very much !

@waruqi waruqi closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants