Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmake v2.6.1的Windows安装包会先删除安装目录下的文件 #1888

Closed
dongnanyanhai opened this issue Dec 5, 2021 · 7 comments
Closed
Labels
Milestone

Comments

@dongnanyanhai
Copy link

描述问题

xmake v2.6.1的Windows安装包会先删除安装目录下的所有文件,用户不小心选错目录的话,问题有点大!

期待的结果

安装程序先检测用户选择的安装目录,如果存在文件或目录,弹出提示告知用户重新选择。

相关环境

请提供编译和运行环境信息,下面是一些必须填写的基础信息,便于我们针对性排查问题:

  • xmake版本:v2.6.1
  • xmake运行平台:win 10
@waruqi
Copy link
Member

waruqi commented Dec 5, 2021

这个跟2.6.1没啥关系,之前的版本也会有这个问题,回头可以尝试从注册表读取之前的安装目录

@dongnanyanhai
Copy link
Author

最好在安装程序那里判断一下目录,我今天选错被删了太多文件了。

好在目录下有个软件用了npm,没想到目录里有几万个小文件救了我一命。

@dongnanyanhai
Copy link
Author

建议尽量不要删除用户目录下的文件,改为提醒用户选择一个空目录,这样比较保险。

@waruqi
Copy link
Member

waruqi commented Dec 5, 2021

建议尽量不要删除用户目录下的文件,改为提醒用户选择一个空目录,这样比较保险。

我只能尝试改进 读取之前注册表实际的历史安装目录,直接卸载之前的版本

加提提示做不了,这个是 nsis 的脚本,我不太熟,不一定它支持这个功能,如果你知道,可以来个 pr 过来

而且通常默认给的路径安装就是了, C:\program files\xmake 不会存在这个问题,所以建议不要随意切换安装目录。

@waruqi
Copy link
Member

waruqi commented Dec 5, 2021

刚稍微改进了下,如果选择的安装目录下有 xmake.exe ,才会尝试选删除历史文件,如果没有,就直接装

b062cae#diff-8a89c99a899893537a7a7e6df063963d3cd3fbda57c6a4fb5babf345a06b6048

@waruqi waruqi added this to the v2.6.2 milestone Dec 5, 2021
@waruqi
Copy link
Member

waruqi commented Dec 5, 2021

目前的改进基本可以了,https://github.com/xmake-io/xmake/actions/runs/1541406506 到这里可以下载安装包做测试,有问题再开

@waruqi waruqi closed this as completed Dec 5, 2021
@dongnanyanhai
Copy link
Author

好的,辛苦了!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants