Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vstudio projects #1959

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Improve vstudio projects #1959

merged 2 commits into from
Jan 7, 2022

Conversation

SirLynix
Copy link
Member

@SirLynix SirLynix commented Jan 6, 2022

Add supports for the following vcxproj xml nodes:

  1. <ExternalIncludePath>
  2. <DisableSpecificWarnings>
  3. <AdditionalLibraryDirectories>
  4. <AdditionalDependencies>
  5. <LanguageStandard>
  6. <LanguageStandard_C>

I had to move common flags building in a separate function because I needed them in _make_configurations (for external include path)

Using <ExternalIncludePath> instead of -external:I fixes the Intellisense issue with "go to definition" or "open file" erroring on external include paths.

The next big step I would like to implement now is rule support, using phony project inside of VS.

@waruqi waruqi merged commit a4943a5 into xmake-io:dev Jan 7, 2022
@waruqi
Copy link
Member

waruqi commented Jan 7, 2022

thanks! 👍

@SirLynix SirLynix deleted the improve_vstudio branch January 11, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants