add keil-c51 toolchain & rules & review #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
May 10, 2022
| function _check(program) | ||
| local c51 = assert(find_tool("c51"), "c51 not found") | ||
| -- make temp source file | ||
| local tmpdir = os.tmpfile() |
There was a problem hiding this comment.
local tmpdir = os.tmpfile() .. ".dir"
waruqi
reviewed
May 10, 2022
| local c51 = assert(find_tool("c51"), "c51 not found") | ||
| -- make temp source file | ||
| local tmpdir = os.tmpfile() | ||
| os.mkdir(tmpdir) |
waruqi
reviewed
May 10, 2022
| os.runv(program, {objfile, "TO", binfile}) | ||
| -- remove files | ||
| os.rmdir(tmpdir) | ||
| end |
waruqi
reviewed
May 10, 2022
| function _check(program) | ||
| -- make temp source file | ||
| local tmpdir = os.tmpfile() | ||
| os.mkdir(tmpdir) |
waruqi
reviewed
May 10, 2022
| local bl51 = assert(find_tool("bl51"), "bl51 not found") | ||
| -- make temp source file | ||
| local tmpdir = os.tmpfile() | ||
| os.mkdir(tmpdir) |
waruqi
reviewed
May 10, 2022
xmake/rules/c51/xmake.lua
Outdated
| import("lib.detect.find_tool") | ||
| local oh = assert(find_tool("oh51"), "oh51 not found") | ||
| os.iorunv(oh.program, {target:targetfile()}) | ||
| cprint("${color.warning} hex file generated %s", target:targetfile() .. ".hex") |
There was a problem hiding this comment.
after_link(function(target, opt)
import("utils.progress")
progress.show(opt.progress, "${color.build.target}generating.$(mode) %s", targetfile)
waruqi
reviewed
May 10, 2022
xmake/rules/c51/xmake.lua
Outdated
| after_link(function(target) | ||
| import("lib.detect.find_tool") | ||
| local oh = assert(find_tool("oh51"), "oh51 not found") | ||
| os.iorunv(oh.program, {target:targetfile()}) |
waruqi
reviewed
May 10, 2022
xmake/rules/c51/xmake.lua
Outdated
| end | ||
| end) | ||
|
|
||
| after_link(function(target) |
There was a problem hiding this comment.
另外，加个 on_changed ，确保仅仅 targetfile 有改动后，才做转换，不要每次都去执行
waruqi
reviewed
May 10, 2022
xmake/toolchains/c51/xmake.lua
Outdated
| import("lib.detect.find_tool") | ||
| import("detect.sdks.find_c51") | ||
| local c51 = find_c51() | ||
|
|
waruqi
reviewed
May 10, 2022
xmake/rules/c51/xmake.lua
Outdated
| import("core.project.depend") | ||
| depend.on_changed(function() | ||
| import("lib.detect.find_tool") | ||
| import("utils.progress") |
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
加入新的Keil_v5里的C51工具链，具体包含C51.exe,BL51.exe,OH51.exe，整合为C51 sdk和C51 toolchain，添加c51.static rule